Expose and use labelMessage with pkg context#12123
Open
philderbeast wants to merge 1 commit into
Open
Conversation
philderbeast
force-pushed
the
add/package-warning-context
branch
2 times, most recently
from
July 16, 2026 20:34
c178f15 to
bcf8228
Compare
tdammers
approved these changes
Jul 17, 2026
zlonast
approved these changes
Jul 18, 2026
- Rename warnMessage to labelMessage - Add punctuation parameter and haddocks - Add since annotation for exposed function - Update expected outputs
philderbeast
force-pushed
the
add/package-warning-context
branch
from
July 19, 2026 00:41
ce01707 to
4fdffc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12019.
warnMessagetolabelMessage1 and export fromDistribution.Simple.UtilslabelMessageThe output of existing tests suffices to show and test this change.
I'll squash commits before applying the merge label if this pull request is approved.
Note
As can be seen in
ppPackageCheckthat returns the warning message, theWarning: package-nameprefix is followed an[explanation-id](like[no-default-language]) and then the explanation description:cabal/Cabal/src/Distribution/PackageDescription/Check/Warning.hs
Lines 89 to 96 in 20fc9ba
QA Notes
Follow the reproduction in the issue, with this pull request checked out locally:
The output from the build should contain
Warning: Cabal-tests [no-default-language].significance: significantin the changelog file.Footnotes
I didn't go with
labelledMessageorlabeledMessagebecause of the US versus UK, AU, NZ etc spelling differences. ↩