Skip to content

Overhaul CI#182

Merged
sjshuck merged 1 commit intohaskell:masterfrom
hasufell:ci-mal-anders
Apr 12, 2026
Merged

Overhaul CI#182
sjshuck merged 1 commit intohaskell:masterfrom
hasufell:ci-mal-anders

Conversation

@hasufell
Copy link
Copy Markdown
Member

@hasufell hasufell commented Apr 11, 2026

What this PR does:

  • test the sdist, not the project!
    • we want to know it can be built from hackage
    • that means we also get rid of cabal freeze
    • and inject --ghc-options='-Werror' manually
  • automatically test all GHCs in the tested-with field
  • upload the plan.json files
  • automatically test the last 4 LTS stackage releases
    • this code is custom shell, but very simple
    • this should also implicitly test that we're compatible with the shipped boot libraries
  • test haddock
  • run cabal check
  • remove caching, we don't really need it
  • use haskell/ghcup-setup over haskell-actions/setup
    • it's simpler and more predictable
    • allows better advanced configuration
  • add matrix to mhs job just in case
  • update actions/checkout to v6

@hasufell hasufell force-pushed the ci-mal-anders branch 14 times, most recently from c655abe to 4c68d3a Compare April 11, 2026 05:23
@hasufell hasufell requested a review from sjshuck April 11, 2026 05:30
@hasufell hasufell force-pushed the ci-mal-anders branch 5 times, most recently from d127e91 to fc2a271 Compare April 11, 2026 06:35
@sjshuck
Copy link
Copy Markdown
Collaborator

sjshuck commented Apr 11, 2026

Reviewing this now @hasufell, thanks.

due to an outstanding issue we need a minor workaround

Is this a blocker?

@hasufell
Copy link
Copy Markdown
Member Author

No, the workaround is in the workflow file. I documented it there.

[.[] | select(startswith("nightly") | not)]
| unique
| sort_by(split("-")[1] | split(".") | map(tonumber))
| .[-(($n | tonumber)):]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double parens needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow. The whole thing is already in single parens.

@sjshuck sjshuck merged commit 06f55a0 into haskell:master Apr 12, 2026
30 checks passed
@sjshuck sjshuck mentioned this pull request Apr 12, 2026
@hasufell
Copy link
Copy Markdown
Member Author

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants