add test for regressions#79
Open
mwotton wants to merge 2 commits into
Open
Conversation
Author
|
I think I have the invariants right now, but I am still getting -Infinity for R-squared, which should range from 0 to 1. |
Collaborator
|
I didn't looked at code closely not I did try to run it. But R² = ∞ could happen if matrix becomes singular. Having more rows that columns is necessary but not sufficient condition. For example it's not possible to make regression with following points: [(0,1),(0,2),(0,3)]. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm having a bit of trouble understanding how the least-squares regression is meant to be called, so I added a failing test with my understanding of the constraints.