Improve submenu header and divider style#956
Open
TetraTheta wants to merge 2 commits intohbstack:mainfrom
Open
Improve submenu header and divider style#956TetraTheta wants to merge 2 commits intohbstack:mainfrom
TetraTheta wants to merge 2 commits intohbstack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how submenu looks like when
columnsis set to2.I personally think this looks bad.
This is how I think it should look like.
Submenu Header and Divider will take full width, instead of '1 column' like other submenu items.
This even works when the number of submenu items is odd.
I've tested this myself via placing modified
_header.scssinassets/hb/modules/header/scss, which will effectively override what is provided byhbstack/header.