Worked on search benchmarking and docs#1301
Merged
VisLab merged 2 commits intohed-standard:mainfrom Apr 8, 2026
Merged
Conversation
|
Claude code review could not run. The request to the Claude API failed (possible causes: billing limit reached, token expired, or service unavailable). Review this PR manually. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the string-search API and benchmark tooling/documentation to focus on list-based search (string_search) and refreshes the search benchmarking/report outputs accordingly.
Changes:
- Replaces the pandas
search_seriesconvenience API withstring_search(strings, ...)returning alist[bool]. - Updates tests, docs, and public exports to reflect the new
string_searchAPI and revised benchmarking narrative. - Refreshes benchmark scripts and reporting to normalize engine labels and add a schema-lookup visualization.
Reviewed changes
Copilot reviewed 9 out of 29 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/models/test_string_search.py | Updates tests to use string_search and assert list outputs. |
| hed/models/string_search.py | Removes pandas dependency; replaces search_series with list-based string_search. |
| hed/models/query_util.py | Docstring formatting tweaks for SearchResult. |
| hed/models/model_constants.py | Simplifies enum docstring text for TopTagReturnType. |
| hed/init.py | Re-exports string_search instead of search_series. |
| docs/search_details.md | Updates docs/benchmarks narrative and API references to list-based search. |
| docs/api/models.rst | Updates API doc entry from search_series to string_search. |
| benchmarks/search_benchmark.py | Migrates benchmarks to string_search, updates engine labels, adjusts parameters. |
| benchmarks/report.py | Normalizes legacy engine labels; updates plot labels; adds schema-lookup plot/table logic. |
|
Claude code review could not run. The request to the Claude API failed (possible causes: billing limit reached, token expired, or service unavailable). Review this PR manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.