path: fix intransitive ordering of a directory against its descendants - #4
Open
shaleh wants to merge 1 commit into
Open
path: fix intransitive ordering of a directory against its descendants#4shaleh wants to merge 1 commit into
shaleh wants to merge 1 commit into
Conversation
The path comparator returned Equal when one path was a prefix of another at a separator boundary, so a directory compared equal to every file beneath it. That makes Ord intransitive: a directory equals two different descendants that do not equal each other. sort_unstable detects the broken order and panics, which showed up when many parent and child paths landed in one change set, for example copying a large tree into a watched repo. Order the ancestor directory before its descendants instead of equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path comparator returned Equal when one path was a prefix of another at a separator boundary, so a directory compared equal to every file beneath it. That makes Ord intransitive: a directory equals two different descendants that do not equal each other. sort_unstable detects the broken order and panics, which showed up when many parent and child paths landed in one change set, for example copying a large tree into a watched repo.
Order the ancestor directory before its descendants instead of equal.
Fixes the issue Philipp-M reports here: helix-editor/helix#14544 (comment)
This does not appear to be OS specific. Any bulk file operation could trigger it.