Bump ua-parser-js from 0.7.18 to 0.7.28#75
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.18 to 0.7.28. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Commits](faisalman/ua-parser-js@0.7.18...0.7.28) Signed-off-by: dependabot[bot] <support@github.com>
Author
|
Superseded by #97. |
madisonrickert
added a commit
to madisonrickert/WaveConductor
that referenced
this pull request
May 29, 2026
Phase 13's first approach drew the bones directly to the swap chain via `ClearColorConfig::None` on Camera3d (order = 1) over the HDR Camera2d at order = 0. In practice the swap chain was not being fully reset between the two cameras: bones accumulated in opaque pixels each frame, the Camera3d frustum eventually covered the particles + UI, and the smear was cropped at the window edges where Camera3d's view ended. Architecturally clean fix (this was carry-forward hellochar#75): - Allocate a window-sized Bgra8UnormSrgb `Image` with `TextureUsages::RENDER_ATTACHMENT` in `spawn_hand_mesh_camera`. - `HandMeshCamera3d`'s `RenderTarget` is that image, not the swap chain. `ClearColorConfig::Custom(Color::NONE)` resets the image to fully transparent each frame, so bones from the previous frame are gone before this frame's geometry is drawn. - `HandMeshCompositorSprite` carries the image as its texture, sized to the window in world units (via `Sprite::custom_size`) and parked on a new `HAND_MESH_COMPOSITOR_LAYER` (RenderLayers 2). - `HandMeshCompositorCamera` is a Camera2d at `order = 2`, sees only the compositor layer, and uses `ClearColorConfig::None` so the main Camera2d's tonemapped swap-chain output stays underneath. Sprites alpha-blend by default, so the bones composite cleanly. Bevy 0.18 specific: `RenderTarget` is now a separate Component required by `Camera` (`#[require(...)]`); the old `Camera::target` field is gone. Spawning the override as a sibling component works. `f32_to_u32_lossy` localises the f32 → u32 cast on window dimensions to one site with documented invariants (`is_finite`, `>= 0.0`), satisfying the deny-on-warning `as_conversions` lint. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps ua-parser-js from 0.7.18 to 0.7.28.
Commits
1d3c98aRevert breaking fix #279 and release as 0.7.28535f11bDelete redundant code642c039Fix #492 LG TV WebOS detection3edacddMerge branch 'master' into developacc0b91Update contributor listf726dcdMerge branch 'master' into develop383ca58More test for tablet devices7c8aa43Minor rearrangement09aa910Add new device & browser: Tesla557cc21More test for latest phones with unique form factor (fold/flip/qwerty/swivel)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.