fix(engine): correct mock call index in multi-track audioMixer test#1144
Merged
Conversation
processCompositionAudio prepares all tracks in parallel (Promise.all),
so for N tracks the mix call lands at index N, not index 1. The 3-track
test was reading calls[1] (the second prepare call) instead of calls[3]
(the mix call), causing indexOf("-filter_complex") to return -1 and the
subsequent assertions to read the wrong args.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
processCompositionAudioprepares all tracks in parallel viaPromise.all, so for N tracks the mix call lands at mock call index N, not index 1. The 3-track test added in hf#1140 was readingcalls[1](the second prepare call) instead ofcalls[3](the actual mix call), causingindexOf("-filter_complex")to return -1 and all subsequent assertions to read the wrong args.Fix
Change
mock.calls[1]?.[0]→mock.calls[3]?.[0]in the multi-track test and addexpect(runFfmpegMock).toHaveBeenCalledTimes(4)to pin the call structure explicitly (3 prepare + 1 mix).Verification
vitest run packages/engine/src/services/audioMixer.test.ts— 6/6 pass.