Skip to content

perf(cli): abort stale studio thumbnails #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
miguel-heygen wants to merge 1 commit into
base: codex/studio-thumbnail-runtime
Choose a base branch
from
Draft

perf(cli): abort stale studio thumbnails #2654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions packages/cli/src/server/studioServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,21 @@ export function createStudioServer(options: StudioServerOptions): StudioServer {
return null;
}
let page: import("puppeteer-core").Page | null = null;
const closePage = () => void page?.close().catch(() => {});
opts.signal.addEventListener("abort", closePage, { once: true });
try {
page = await browser.newPage();
await page.setViewport({ width: opts.width || 1920, height: opts.height || 1080 });
if (opts.signal.aborted) return null;
const width = opts.width || 1920;
const height = opts.height || 1080;
await page.setViewport({
width,
height,
deviceScaleFactor: Math.max(
0.1,
Math.min(1, opts.outputWidth / width, opts.outputHeight / height),
),
});
await page.goto(opts.previewUrl, { waitUntil: "domcontentloaded", timeout: 10000 });
await page
.waitForFunction(
Expand Down Expand Up @@ -543,12 +555,15 @@ export function createStudioServer(options: StudioServerOptions): StudioServer {
)) as Buffer;
return screenshot;
} catch (err) {
console.warn(
"[Studio] Thumbnail generation failed:",
err instanceof Error ? err.message : err,
);
if (!opts.signal.aborted) {
console.warn(
"[Studio] Thumbnail generation failed:",
err instanceof Error ? err.message : err,
);
}
return null;
} finally {
opts.signal.removeEventListener("abort", closePage);
await page?.close().catch(() => {});
}
},
Expand Down
Loading