Skip to content

feat(studio): add playback hotkeys#961

Closed
AjTheSpidey wants to merge 1 commit into
heygen-com:mainfrom
AjTheSpidey:codex/studio-playback-hotkeys
Closed

feat(studio): add playback hotkeys#961
AjTheSpidey wants to merge 1 commit into
heygen-com:mainfrom
AjTheSpidey:codex/studio-playback-hotkeys

Conversation

@AjTheSpidey
Copy link
Copy Markdown

Adds the playback hotkeys from #905.

M toggles preview mute, and Shift+L / Ctrl+L toggle loop playback. Shift+L is handled before the normal JKL shuttle path so it does not accidentally start forward playback. I also added the new shortcuts to the keyboard panel in the player controls.

Checked locally:

  • bun run --filter @hyperframes/studio typecheck
  • bun run --filter @hyperframes/studio test -- src/player/hooks/usePlaybackKeyboard.test.ts
  • bun run --filter @hyperframes/studio test -- src/player/hooks/useTimelinePlayer.test.ts
  • bun run lint
  • bun run format:check
  • bun run --filter @hyperframes/studio build

Small Windows note: I had to run install with a local Bun cache and --ignore-scripts because the prepare hook calls Unix test here, but the checks above are the ones I used before opening this.

Closes #905

@miguel-heygen
Copy link
Copy Markdown
Collaborator

Hi @AjTheSpidey, thanks for trying to contribute to HyperFrames! The issue was already solved, because the PR I chose didn't have any failed checks or merge conflicts, you can try to address another issue next time! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(studio) Add keyboard shortcuts to toggle muting and looping (NLE standards)

2 participants