Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"citty": "^0.2.1",
"compare-versions": "^6.1.1",
"esbuild": "^0.25.12",
"fontkit": "^2.0.4",
"giget": "^3.2.0",
"hono": "^4.0.0",
"onnxruntime-node": "^1.20.0",
Expand All @@ -47,6 +48,7 @@
"@hyperframes/producer": "workspace:*",
"@hyperframes/studio": "workspace:*",
"@types/adm-zip": "^0.5.7",
"@types/fontkit": "^2.0.9",
"@types/mime-types": "^3.0.1",
"@types/node": "^25.0.10",
"linkedom": "^0.18.12",
Expand Down
176 changes: 176 additions & 0 deletions packages/cli/src/capture/fontMetadataExtractor.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
import { describe, expect, it } from "vitest";
import { mkdtempSync, rmSync, existsSync, readFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import {
canonicalizeFamily,
extractFontMetadata,
inferWeightFromSubfamily,
} from "./fontMetadataExtractor.js";

describe("inferWeightFromSubfamily", () => {
// The concatenated forms were always handled. The spaced and hyphenated
// forms were the bug Copilot flagged on PR #987 — "Extra Light" used to
// fall through to the 400 default before the whitespace-normalization fix.
describe("concatenated forms (already handled)", () => {
it.each([
["Thin", 100],
["ExtraLight", 200],
["UltraLight", 200],
["Light", 300],
["Regular", 400],
["Medium", 500],
["SemiBold", 600],
["DemiBold", 600],
["Bold", 700],
["ExtraBold", 800],
["UltraBold", 800],
["Black", 900],
["Heavy", 900],
])("%s → %d", (subfamily, expected) => {
expect(inferWeightFromSubfamily(subfamily)).toBe(expected);
});
});

describe("spaced forms (the bug fix)", () => {
it.each([
["Extra Light", 200],
["Ultra Light", 200],
["Semi Bold", 600],
["Demi Bold", 600],
["Extra Bold", 800],
["Ultra Bold", 800],
])("%s → %d", (subfamily, expected) => {
expect(inferWeightFromSubfamily(subfamily)).toBe(expected);
});
});

describe("hyphenated forms (the bug fix)", () => {
it.each([
["Extra-Light", 200],
["Semi-Bold", 600],
["Extra-Bold", 800],
])("%s → %d", (subfamily, expected) => {
expect(inferWeightFromSubfamily(subfamily)).toBe(expected);
});
});

describe("composite styles", () => {
it("Bold Italic still detects Bold", () => {
expect(inferWeightFromSubfamily("Bold Italic")).toBe(700);
});
it("Semi Bold Italic still detects SemiBold (priority over Bold)", () => {
expect(inferWeightFromSubfamily("Semi Bold Italic")).toBe(600);
});
it("ExtraBold Italic still detects ExtraBold (priority over Bold)", () => {
expect(inferWeightFromSubfamily("ExtraBold Italic")).toBe(800);
});
});

it("unknown subfamily falls back to 400 (Regular)", () => {
expect(inferWeightFromSubfamily("Headline")).toBe(400);
expect(inferWeightFromSubfamily("")).toBe(400);
expect(inferWeightFromSubfamily("Some Random Style")).toBe(400);
});

it("is case-insensitive", () => {
expect(inferWeightFromSubfamily("EXTRA LIGHT")).toBe(200);
expect(inferWeightFromSubfamily("extra light")).toBe(200);
expect(inferWeightFromSubfamily("ExTrA LiGhT")).toBe(200);
});
});

describe("canonicalizeFamily", () => {
it("returns family unchanged when no weight token is trailing", () => {
expect(canonicalizeFamily("Inter")).toEqual({
canonical: "Inter",
inferredWeight: null,
});
expect(canonicalizeFamily("Tiempos Headline")).toEqual({
canonical: "Tiempos Headline",
inferredWeight: null,
});
expect(canonicalizeFamily("Söhne Breit")).toEqual({
canonical: "Söhne Breit",
inferredWeight: null,
});
});

it("strips trailing weight tokens and surfaces the implied weight", () => {
expect(canonicalizeFamily("Inter Medium")).toEqual({
canonical: "Inter",
inferredWeight: 500,
});
expect(canonicalizeFamily("Inter Light")).toEqual({
canonical: "Inter",
inferredWeight: 300,
});
expect(canonicalizeFamily("Inter Bold")).toEqual({
canonical: "Inter",
inferredWeight: 700,
});
expect(canonicalizeFamily("Funnel Display Light")).toEqual({
canonical: "Funnel Display",
inferredWeight: 300,
});
});

it("preserves width modifiers before the weight token", () => {
expect(canonicalizeFamily("Inter Tight Medium")).toEqual({
canonical: "Inter Tight",
inferredWeight: 500,
});
});

it("emits 950 for ExtraBlack / UltraBlack (mirrors foundry intent)", () => {
expect(canonicalizeFamily("Inter ExtraBlack")).toEqual({
canonical: "Inter",
inferredWeight: 950,
});
});

it("returns empty input unchanged", () => {
expect(canonicalizeFamily("")).toEqual({
canonical: "",
inferredWeight: null,
});
});
});

describe("extractFontMetadata", () => {
// Light integration tests against the public surface — uses a real
// temp directory and verifies the manifest shape. Doesn't require
// fixture font binaries; the non-existent and empty-directory cases
// exercise the happy paths for the surrounding pipeline.

it("returns an empty manifest when the fonts directory doesn't exist", () => {
const tmp = mkdtempSync(join(tmpdir(), "hf-font-test-"));
try {
const outputPath = join(tmp, "manifest.json");
const manifest = extractFontMetadata(join(tmp, "does-not-exist"), outputPath);
expect(manifest.files).toEqual([]);
expect(manifest.families).toEqual([]);
expect(manifest.unidentified).toEqual([]);
expect(existsSync(outputPath)).toBe(true);
const written = JSON.parse(readFileSync(outputPath, "utf-8")) as typeof manifest;
expect(written.files).toEqual([]);
expect(written.meta.tool).toBe("fontkit");
expect(typeof written.meta.generatedAt).toBe("string");
} finally {
rmSync(tmp, { recursive: true, force: true });
}
});

it("writes a manifest with the documented meta shape", () => {
const tmp = mkdtempSync(join(tmpdir(), "hf-font-test-"));
try {
const outputPath = join(tmp, "manifest.json");
const manifest = extractFontMetadata(tmp, outputPath);
expect(manifest.meta.tool).toBe("fontkit"); // no version hardcoded — moves with the dep
// generatedAt is an ISO string
expect(manifest.meta.generatedAt).toMatch(/^\d{4}-\d{2}-\d{2}T/);
} finally {
rmSync(tmp, { recursive: true, force: true });
}
});
});
Loading
Loading