feat: Add open/close all Godley tables menu items. For feature #173.#657
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds backend enumeration and named-item resolution for Godley tables, exposes an async TypeScript bridge, refactors CommandsManager to open/close Godley tables by ID, and wires bulk Open/Close actions into the application Edit menu and Godley context menu. ChangesGodley Table Bulk Operations
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts`:
- Around line 894-897: openAllGodleyTables currently calls openGodleyTable(id)
without awaiting it, causing fire-and-forget async calls and possible unhandled
rejections; update openAllGodleyTables to await the async opens (either
sequentially with "for ... of" + await openGodleyTable(id) or concurrently with
Promise.all over minsky.allGodleyTables().map(id => openGodleyTable(id))) and
ensure errors are propagated/handled so unhandled rejections are avoided.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fb3e2587-e75f-416f-9509-e7474ca49f6d
📒 Files selected for processing (6)
gui-js/apps/minsky-electron/src/app/managers/ApplicationMenuManager.tsgui-js/apps/minsky-electron/src/app/managers/CommandsManager.tsgui-js/apps/minsky-electron/src/app/managers/ContextMenuManager.tsgui-js/libs/shared/src/lib/backend/minsky.tsmodel/minsky.ccmodel/minsky.h
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds UI commands and backend support to open/close Godley table windows in bulk, as well as refactors Godley-table opening to be ID-based.
Changes:
- Added a backend API to enumerate Godley table IDs and exposed it to the JS/Electron client.
- Added “Open All Godley Tables” / “Close All Godley Tables” actions to the application menu and Godley context menu.
- Updated Godley table opening logic to operate on item IDs and to (re)populate
namedItemswhen needed.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| model/minsky.h | Declares allGodleyTables() and moves itemFromNamedItem() to an out-of-line definition. |
| model/minsky.cc | Implements itemFromNamedItem() fallback population and adds allGodleyTables() implementation. |
| gui-js/libs/shared/src/lib/backend/minsky.ts | Exposes allGodleyTables() to the TypeScript client wrapper. |
| gui-js/apps/minsky-electron/src/app/managers/ContextMenuManager.ts | Adds context menu entries for opening/closing all Godley tables and adjusts single-table open behavior. |
| gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts | Adds bulk open/close commands and refactors Godley opening to accept an ID. |
| gui-js/apps/minsky-electron/src/app/managers/ApplicationMenuManager.ts | Adds application menu items for opening/closing all Godley tables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is
Summary by CodeRabbit
New Features
Bug Fixes