Use direct setter calls instead of using commons-beanutils#686
Closed
ppalaga wants to merge 1 commit intohighsource:masterfrom
Closed
Use direct setter calls instead of using commons-beanutils#686ppalaga wants to merge 1 commit intohighsource:masterfrom
ppalaga wants to merge 1 commit intohighsource:masterfrom
Conversation
Author
|
I hope I have covered all properties which were supposed to be exposed. It looks like there is not much coverage of those features. |
Collaborator
|
Missing properties, this should be reworked but could be interesting to remove |
Author
|
Thanks for reviewing @laurentschoelens. Are you taking the effort over? Othewise I'd be ready to improve this PR if you give me some hits. |
Collaborator
|
For the moment I'll go first with #685 In any case, that would go w/ 4.1 |
Author
|
Thanks for the hint. Let me try with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #684
This is an alternative approach to #685