fix(utils): derive pull extensions from CDN URLs - #26
Merged
Conversation
Library filenames can disagree with the real asset (e.g. MultiClipEdit rows named *.json whose baked source is *.mp4). Prefer content-disposition or the URL path suffix when naming downloaded files. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Welbert Castro <welberthime@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response-content-dispositionfilename, then path suffix) instead of the library media name alone.*.jsonbut whose baked export is*.mp4.extension_from_urlhelper in the API utils docs.Test plan
gopro-api info <multi-clip-edit-id> --tsvstill lists the bakedfilesrow with a.mp4URLgopro-api pull <multi-clip-edit-id> /tmp/gopro-testsaves…000.mp4(not…000.json).mp4video and confirm the local name/extension is unchanged.jpg)Made with Cursor