Support encoding/decoding MessagePackTimestamp using non-MessagePack encoders/decoders#56
Open
fumoboy007 wants to merge 1 commit into
Open
Support encoding/decoding MessagePackTimestamp using non-MessagePack encoders/decoders#56fumoboy007 wants to merge 1 commit into
MessagePackTimestamp using non-MessagePack encoders/decoders#56fumoboy007 wants to merge 1 commit into
Conversation
…k encoders/decoders. `MessagePackTimestamp` currently requires a `MessagePackEncoder`/`MessagePackDecoder` for encoding/decoding. Using a non-MessagePack encoder/decoder results in a fatal error. A client may want to use a human-readable serialization format, such as JSON, in automated tests to make it easier to read and write the test. However, if a `MessagePackTimestamp` is present anywhere in the data structure to be serialized/deserialized, the test will crash. To enable the above use case, we add fallback behavior for non-MessagePack encoders/decoders when encoding/decoding `MessagePackTimestamp`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessagePackTimestampcurrently requires aMessagePackEncoder/MessagePackDecoderfor encoding/decoding. Using a non-MessagePack encoder/decoder results in a fatal error.A client may want to use a human-readable serialization format, such as JSON, in automated tests to make it easier to read and write the test. However, if a
MessagePackTimestampis present anywhere in the data structure to be serialized/deserialized, the test will crash.To enable the above use case, we add fallback behavior for non-MessagePack encoders/decoders when encoding/decoding
MessagePackTimestamp.