Open
Conversation
this removes the check in L218 because evaluation of Scope is now deferred:wq
we check if a function is staged through defCtx, so we can substitute the symbol there
_instr function only returns the block IR, whereas _gen functions will include the shape propagation
…into add-cache
Contributor
|
Please resolve the conflicts. |
since the parameters of the instrumented ctor function is only used for printing and not shape propagation, we don't need to force the ctor to only have one paramlist
this avoids collision of a ConcreteClassSymbol and ModuleSymbol of a class with no paramters and its companion module, both having the same runtime value and thus the same key
Contributor
Author
|
hmm, |
Contributor
|
Unfortunately, I still don't know why the order of private fields does not seem stable :/ EDIT: It's being investigated and fixed at #459. |
LPTK
force-pushed
the
hkmc2
branch
2 times, most recently
from
f5b9c17 to
323afbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populates the function cache and generatorMap for each staged module