Skip to content

Make “Tag der Befreiung” reoccur in Berlin in 2025#293

Open
michaelem wants to merge 2 commits into
holidays:masterfrom
projo-berlin:master
Open

Make “Tag der Befreiung” reoccur in Berlin in 2025#293
michaelem wants to merge 2 commits into
holidays:masterfrom
projo-berlin:master

Conversation

@michaelem
Copy link
Copy Markdown

@rpellerin
Copy link
Copy Markdown

Hello @ppeble, could this PR be merged please? ☺️
Thank you!

@chrp
Copy link
Copy Markdown
Contributor

chrp commented Apr 28, 2025

@ppeble Could you please merge this PR?

@DagonWat
Copy link
Copy Markdown
Contributor

Hi @ppeble, I know this change is late, but I think its still worth to merge to keep historical data valid.

@ppeble
Copy link
Copy Markdown
Member

ppeble commented Apr 27, 2026

I apologize for the atrocious delay. If you resolve the conflicts I will happily merge and get it released in the gem.

@DagonWat
Copy link
Copy Markdown
Contributor

Hello @michaelem could you please resolve the conflicts? Alternatively I can hop on this topic on weekend and create new PR from my fork of yours work.

@michaelem
Copy link
Copy Markdown
Author

@DagonWat @ppeble resolved!

@ppeble
Copy link
Copy Markdown
Member

ppeble commented Apr 30, 2026

@michaelem All looks good, just need DCO to pass! Once you get it passing I will merge.

@DagonWat
Copy link
Copy Markdown
Contributor

@michaelem its basically that you need to sign your commits to get them to master, you can see more on this failed check page - https://github.com/holidays/definitions/pull/293/checks?check_run_id=73676321170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants