Skip to content

FIX test: update common types with Tuple#2

Open
mathben wants to merge 1 commit intoholochain:mainfrom
mathben:fix_test
Open

FIX test: update common types with Tuple#2
mathben wants to merge 1 commit intoholochain:mainfrom
mathben:fix_test

Conversation

@mathben
Copy link
Copy Markdown

@mathben mathben commented Jan 18, 2026

Check #1

Summary by CodeRabbit

  • Refactor
    • Updated a public type used for cell identifiers to enforce immutability and improve API consistency.
    • This change tightens type contracts, reducing risk of accidental modification when interacting with the API.
    • No runtime behavior changes are expected for end-users; existing integrations should continue to work as before.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 18, 2026

Walkthrough

Updates the CellId type alias in holochain_client/api/common/types.py from list notation [DnaHash, AgentPubKey] to tuple notation Tuple[DnaHash, AgentPubKey] and adds an explicit Tuple import from typing.

Changes

Cohort / File(s) Summary
Type alias update
holochain_client/api/common/types.py
Replaced CellId annotation from list-style [DnaHash, AgentPubKey] to Tuple[DnaHash, AgentPubKey]; added Tuple import from typing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the main change: updating the CellId type from a list-like annotation to a Tuple type in common types to fix test issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cocogitto-bot
Copy link
Copy Markdown

cocogitto-bot bot commented Jan 18, 2026

❌ Found 0 compliant commit and 1 non-compliant commits in e8fc8bc.

Commit e8fc8bc by @mathben is not conform to the conventional commit specification :

  • message: Fix test by updating common types
  • cause:
    Missing commit type separator `:`
    
    Caused by:
         --> 1:4
          |
        1 | Fix test by updating common types
          |    ^---
          |
          = expected scope or type_separator
    

@mathben mathben changed the title Fix test by updating common types FIX test: update common types with Tuple Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant