perf(request): fast-path QUERY methods#376
Merged
Merged
Conversation
Member
Author
|
Hi @yusukebe, |
Member
|
@usualoma Thank you for the PR! One thing I realized: |
Member
Author
|
@yusukebe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a very small optimization. It does not change behavior in any way.
Add
QUERYto the fast path innormalizeIncomingMethod.Node.js
http.createServer()already supports receivingQUERYrequests and exposing the method throughreq.method. Support was introduced in Node.js v22.2.0 via nodejs/node#52701 and later backported to Node.js v20.19.3.This change avoids an unnecessary
toUpperCase()call and makes the standardized method explicitly recognized by the normalization fast path.QUERYis added only to the exact-uppercase fast path. Lowercase and mixed-case variants remain unchanged because HTTP method names are case-sensitive.