feat: destination metadata & delivery_metadata#542
Conversation
Add two new fields to the Destination model: - delivery_metadata: Static key-value pairs merged into event data on delivery - metadata: Arbitrary contextual information stored but not sent with events Both fields are map[string]string for simplicity and consistency with existing Config and Credentials fields. The metadata field reuses the existing Metadata type from event.go.
- Add DeliveryMetadata and Metadata fields to Destination struct - Implement Redis persistence for both fields in UpsertDestination - Add deserialization logic in parseRedisHash to handle optional fields - Update test suite to verify persistence of new fields - Add test coverage for nil field handling
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
|
@claude - should we cover the changes in this PR anywhere within ./docs? |
|
Claude finished @leggetter's task —— View job Documentation Review Complete
AnalysisThis PR adds two new fields to destinations:
Key Implementation DetailsFrom the code review:
RecommendationYes, this should be documented in 1.
|
…-metadata # Conflicts: # cmd/e2e/api_test.go
|
there's some issue with destwebhookstandard, will fix in the v0.8.0 branch |
|
@alexluong - should/do we have an issue to support adding something related to this to the Portal UI? |
|
@leggetter great question, for delivery_metadata, I do think so. Let me ping Thomas on Slack. Let's keep the original issue opened until the portal is fully suppoted? |
implements #534 & #537