refactor: session migration to PSR-4#136
Merged
Merged
Conversation
The legacy session handler is now just a shim around the modern session handler which is the real thing
…om Horde_Session to HordeSession
Test Refactor: Now uses a real Token::null('test-secret-key') instance and
round-trips a real generated token. Added testSessionTokenIncorrect for an
explicitly invalid header value.
Refs #131
…oken Test refactor: replaced Horde_Session mock with a real Token::null instance and a freshToken() helper that signs with HordeSession::CSRF_SEED. Refs #131
Session lifecycle calls (regenerate, close, regenerate_due) stay on the shim for now; only the CSRF token check moves to the modern token service. Refs #131
Reads and writes go through HordeSession scoped accessors. Cache wire format diverges from the legacy Horde_Pack-wrapped values; stale entries fall through as cache misses. Refs #131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port multiple places from PSR-0 Horde_Session to PSR-4 HordeSession or Horde\Token\Token.
Part of the grander #131 topic