feat(core): wire EAS 16.0 Find command to IMP search backend#137
Merged
Conversation
Implement getFindResults() by mapping Find params to the existing getSearchResults() IMAP path via QueryMapper. Add resolveLongIdForUid() so ItemOperations can open Find hits when iOS sends a virtual All Mailboxes folder id (M + UID).
6 tasks
ralflang
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire EAS 16.0 Find command to IMP/IMAP backend
Summary
Implements
Horde_Core_ActiveSync_Driver::getFindResults()andresolveLongIdForUid()so the Horde ActiveSync Find handler can search mail and open results on EAS 16.0 clients (tested with iPhone).This PR depends on the companion
horde/activesyncPR that adds the Find protocol handler,Horde_ActiveSync_Find_*types, andHorde_ActiveSync_Driver_Base::getFindResults().Motivation
Horde_ActiveSync_Request_FindcallsgetFindResults()on the ActiveSync driver. The core IMP driver must map Find parameters to the existing Search/IMAP backend and support ItemOperations fetch when iOS uses a virtual All Mailboxes folder id (M+ message UID, e.g.M166562).Changes
getFindResults()Horde_ActiveSync_Find_ParamstoHorde_ActiveSync_Search_ParamsviaHorde_ActiveSync_Find_QueryMappergetSearchResults()(shared IMAP search path, result cache, pagination)Horde_ActiveSync_Find_Resultswith appropriate Find store status codesresolveLongIdForUid()Horde_ActiveSync_Imap_Adapter::resolveLongIdForUid()mailbox:uidwhen ItemOperations receives a virtual folder id that is not in the device folder cacheFiles in this PR
Modified
lib/Horde/Core/ActiveSync/Driver.phpArchitecture
Test plan
horde/activesyncFind PRHorde_Core_ActiveSynctests still passRelated PR
horde/activesync: Add EAS 16.0 Find command support (protocol, IMAP adapter, ItemOperations fallback)Suggested commit message
Author
Torben Dannhauer torben@dannhauer.de