Skip to content

Bug: Fix to flatten buildings when 3D toggle is off#25

Merged
hgosalia merged 1 commit into
mainfrom
bug/3D-mode
Jun 3, 2026
Merged

Bug: Fix to flatten buildings when 3D toggle is off#25
hgosalia merged 1 commit into
mainfrom
bug/3D-mode

Conversation

@hgosalia
Copy link
Copy Markdown
Member

@hgosalia hgosalia commented Jun 3, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

📋 PR Summary

Title: Bug: Fix to flatten buildings when 3D toggle is off
4 files changed: +35 additions, -8 deletions

Description

This PR introduces a fix to ensure that buildings are flattened when the 3D toggle is turned off, addressing an issue where 3D buildings remained visible under certain map styles. The apply3DBuildings function was modified to check for native fill-extrusion layers and set their visibility based on the 3D toggle state. Additionally, the timeout values in the test setup and photo upload functions were increased to accommodate longer loading times, enhancing the reliability of the tests. A new test case was also added to verify that clearing the map cache triggers a success toast notification.

Files

  • js/map.js — Modified: _patchStyleWater, applyExtraLayers
  • tests/helpers/test-setup.js — Modified: setupApp, uploadTestPhotos
  • tests/playwright.config.js — +0/-1
  • tests/specs/settings-export-import.spec.js — +21/-0

@hgosalia hgosalia merged commit 8ee4a04 into main Jun 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant