fix(triton): uncross Q/K halves in fused_rotary_emb#6429
Open
Solaris-star wants to merge 1 commit into
Open
Conversation
out_q1 was computed from K and out_k0 from Q, so half of each tensor got the other tensor's rotary transform. Also use k_token_stride for off_k1 (was accidentally q_token_stride). Fixes hpcaitech#6428 Signed-off-by: Solaris-star <820622658@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
fused_rotary_emb, two of the four rotary outputs were computed from the wrong tensor:Correct RoPE half-rotation is:
Also fixes
off_k1usingq_token_strideinstead ofk_token_stride.Linked Issue
Closes #6428