thor: include startup stats in auditThorSystemEvent("Startup") and co-locate with recordGlobalMetrics#21154
Draft
Copilot wants to merge 2 commits intocandidate-10.2.xfrom
Draft
thor: include startup stats in auditThorSystemEvent("Startup") and co-locate with recordGlobalMetrics#21154Copilot wants to merge 2 commits intocandidate-10.2.xfrom
Copilot wants to merge 2 commits intocandidate-10.2.xfrom
Conversation
…o recordGlobalMetrics Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com> Agent-Logs-Url: https://github.com/hpcc-systems/HPCC-Platform/sessions/617fd6b8-d9ea-4e0a-ac6e-9e9b807c9718
Copilot
AI
changed the title
[WIP] Update auditThorSystemEvent to include additional args and reorder calls
thor: include startup stats in auditThorSystemEvent("Startup") and co-locate with recordGlobalMetrics
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auditThorSystemEvent("Startup")was called before startup metrics were computed, so the audit log captured no timing or cost data. TherecordGlobalMetricscall with those stats was placed separately after.Changes
thgraphmanager.cpp: RefactoredauditThorSystemEventBuilderto accept optionalstd::initializer_list<StatisticKind>/std::initializer_list<stat_type>params, formatting each stat asname=valueviaqueryStatisticName+formatStatistic. Existing 3-arg overload delegates to this. Added matchingauditThorSystemEventpublic overload.thgraphmanager.hpp: Declared the new overload; added#include "jstats.h"and#include <initializer_list>.thmastermain.cpp: MovedauditThorSystemEvent("Startup")andauditStartLogged = trueto immediately afterrecordGlobalMetrics, passing the same startup stats:📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.