Skip to content

HPCC-35977 feat(esp) When deploying a query, record the source in the workunit#21191

Open
ghalliday wants to merge 1 commit intohpcc-systems:candidate-9.14.xfrom
ghalliday:issue35977
Open

HPCC-35977 feat(esp) When deploying a query, record the source in the workunit#21191
ghalliday wants to merge 1 commit intohpcc-systems:candidate-9.14.xfrom
ghalliday:issue35977

Conversation

@ghalliday
Copy link
Copy Markdown
Member

@ghalliday ghalliday commented Apr 9, 2026 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@ghalliday ghalliday requested a review from asselitx April 9, 2026 11:18
@ghalliday
Copy link
Copy Markdown
Member Author

ghalliday commented Apr 9, 2026

Both a bugfix and a feature. A previous change (HPCC-34962) fixed a bug, but meant it was not possible to link the queries back to the original.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

🔄 Upmerge Test Results

Status: ✅ All branches merged successfully
PR: #21191 - HPCC-35977 feat(esp) When deploying a query, record the source in the workunit
Base Branch: candidate-9.14.x
Test Time: 2026-04-09 11:19:25 UTC

✅ Successful Branches (3)

  • candidate-10.0.x
  • candidate-10.2.x
  • master
    This comment was automatically generated by the upmerge test workflow.

@ghalliday ghalliday requested a review from mckellyln April 9, 2026 14:50
asselitx
asselitx requested changes Apr 9, 2026
View reviewed changes
Comment thread esp/services/ws_workunits/ws_workunitsService.cpp

StringBuffer originalDllName(sourceFilename);
if (!originalDllName.length())
originalDllName.append(name).append(SharedObjectExtension);
Copy link
Copy Markdown
Contributor

@asselitx asselitx Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be sensible to ensure name is non-empty somewhere as I don't see that name is validated to be non-empty in the calling chain. It is passed through from the incoming request.

@ghalliday
HPCC-35977 feat(esp) When deploying a query, record the source in the…
9882270 
… workunit

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@ghalliday ghalliday requested a review from asselitx April 10, 2026 14:32
mckellyln
mckellyln approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mckellyln mckellyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok
Approved.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🔄 Upmerge Test Results

Status: ✅ All branches merged successfully
PR: #21191 - HPCC-35977 feat(esp) When deploying a query, record the source in the workunit
Base Branch: candidate-9.14.x
Test Time: 2026-04-10 17:28:01 UTC

✅ Successful Branches (3)

  • candidate-10.0.x
  • candidate-10.2.x
  • master
    This comment was automatically generated by the upmerge test workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mckellyln mckellyln mckellyln approved these changes

@asselitx asselitx asselitx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ghalliday @mckellyln @asselitx