scripts/check_kernel_freshness: include kernel_dir in stale report items#889
scripts/check_kernel_freshness: include kernel_dir in stale report items#889Dev-X25874 wants to merge 3 commits into
Conversation
|
Hi @Dev-X25874, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/huggingface/kernels-community/blob/main/CONTRIBUTING.md for more details. |
|
Hey @sayakpaul, just wanted to flag that the Looking at the job logs, the Would you be able to re-run the security audit job or confirm it's a known infra issue? Happy to address any actual findings if they come through. Thanks! |
Closes #879
What does this PR do?
Adds
kernel_dirto each line in the Slack freshness report so stale alerts identify which local directory needs updating, not just the upstream URL.Motivation
Several kernels share the same upstream URL. For example
flash-attn2,flash-attn3,flash-attn4,layer-norm,rotary, andvllm-flash-attn3all point to the same flash-attention repo. When any go stale, the current report prints the same URL multiple times with no indication of which directory is behind, making the alert unactionable. Thekernel_dirkey is already populated in every result dict — it was just never used when building the output string.Changes
scripts/check_kernel_freshness.py: one-line format string change in_format_freshness_reportto prependkernel_dirto each report linescripts/test_kernel_freshness_lookup.py: addedtest_freshness_report_includes_kernel_dir— calls_format_freshness_reportwith two results sharing a source URL, asserts bothkernel_dirvalues appear in the outputTesting
cd scripts python test_kernel_freshness_lookup.pyNew test fails on original code, passes after the fix.
Checklist