fix: serialize ContinuousBatchingConfig properly instead of null (#47039)#47415
Closed
webtecnica wants to merge 1 commit into
Closed
fix: serialize ContinuousBatchingConfig properly instead of null (#47039)#47415webtecnica wants to merge 1 commit into
webtecnica wants to merge 1 commit into
Conversation
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #47039 —
ContinuousBatchingConfigwas serializing asnullinGenerationConfig.to_json_string()because it lacked ato_dict()method and its nestedCompileConfigfields weren't being rehydrated after JSON round-trip.Changes
src/transformers/generation/configuration_utils.pyContinuousBatchingConfig.to_dict()— New method that serializes the instance to a dict, properly callingto_dict()on nestedCompileConfigfields (varlen_compile_config,decode_compile_config).ContinuousBatchingConfig.__post_init__()— Added rehydration of nestedCompileConfigfrom dicts (handles the deserialization path after JSON round-trip).GenerationConfig.__init__()— Added rehydration ofContinuousBatchingConfigfrom dict when a plain dict is passed (e.g., fromfrom_pretrainedafter JSON deserialization).tests/generation/test_configuration_utils.pytest_serialize_generation_continuous_batching_config— Verifies:ContinuousBatchingConfigtype and valuesCompileConfigfields are properly rehydratedcontinuous_batching_config: null_compile_all_devicesis not leaked throughCompileConfigserializationWho can review?
@Rocketknight1 @remi-or