fix: handle list input for special_tokens (#47110)#47416
Closed
webtecnica wants to merge 2 commits into
Closed
Conversation
added 2 commits
July 19, 2026 10:48
…e#47110) Prevents AttributeError when special_tokens is passed as a list instead of dict by checking isinstance before calling .keys().
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #47110
Adds a TypeError guard in
add_special_tokensto handle the case when a list is passed asspecial_tokens_dictinstead of a dict. Previously, passing a list would raise a cryptic'list' object has no attribute 'keys'(orValueError: dictionary update sequence element has length...). Now it raises a clear TypeError with guidance on the expected format.Who can review?
@ArthurZucker @itazap