Skip to content

Introduce DATADOG_HOST env var #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaloo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Introduce DATADOG_HOST env var #78

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf985d9
Introduce DATADOG_HOST env var
michaloo Sep 26, 2018
d56d6dc
Require process.env.DATADOG_HOST
michaloo Sep 27, 2018
5c7ccaf
Update changelog
michaloo Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 0.13.17
* introduce a `DATADOG_HOST` environment variable to take precedence generic `HOST` env var

# 0.13.16
* Explicitly handle too large kraken notification payloads
* Adds devMode utility
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "hull",
"version": "0.13.16",
"version": "0.13.17",
"description": "A Node.js client for hull.io",
"main": "lib",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion src/infra/instrumentation/instrumentation-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class InstrumentationAgent {
if (process.env.DATADOG_API_KEY) {
this.metrics = metrics;
metrics.init({
host: process.env.HOST,
host: process.env.DATADOG_HOST || process.env.HOST,
Copy link
Copy Markdown
Contributor

@sbellity sbellity Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I would fallback to a hardcoded value here. It will be easier to manage and make sure we don't send a different host by default for each new connector if the DATADOG_HOST variable is not set.

Copy link
Copy Markdown
Contributor Author

@michaloo michaloo Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, not sure about putting our infra specific URL in this library. What we can do differently to achieve what's important to you is to exit the process early with a descriptive error when DATADOG_HOST env var is missing and we have DATADOG_API_KEY present.
@sbellity @gabrielnau?

});
dogapi.initialize({ api_key: process.env.DATADOG_API_KEY });
this.dogapi = dogapi;
Expand Down