fix: support Vulkan SDK 1.4.313.0+ on Windows using silent installer#25
Open
hollykbuck wants to merge 2 commits into
Open
fix: support Vulkan SDK 1.4.313.0+ on Windows using silent installer#25hollykbuck wants to merge 2 commits into
hollykbuck wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Windows installation failure for Vulkan SDK versions 1.4.313.0 and later.
The Problem
Starting from version 1.4.313.0, LunarG changed the internal structure of the Vulkan SDK Windows installer. As a result, the previous method of simply extracting the
.exevia7zno longer produces the expected directory structure (Headers, Libs, etc. are missing or misplaced).The Solution
I have updated the
install_windowsfunction to:1.4.313.0and above, it executes the installer with CLI flags (--root,--accept-licenses,--default-answer,--confirm-command install) to perform a proper installation.1.4.313.0still use the7zextraction method to ensure no regression.Verification
I have verified this fix in my own project's CI pipeline. You can see the successful installation here:
hollykbuck/qwen3-asr.cpp/actions/runs