Skip to content

[DEV-22328] - client to hfapi2#115

Open
buschwaker wants to merge 4 commits intov2from
DEV-22328_client_to_hfapi
Open

[DEV-22328] - client to hfapi2#115
buschwaker wants to merge 4 commits intov2from
DEV-22328_client_to_hfapi

Conversation

@buschwaker
Copy link
Copy Markdown

No description provided.

Comment on lines +13 to +14
:param data: token request data
:return: refreshed token data
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:param data: Token request data
:return: Refreshed token data

survey: SurveySchemaTypeALogResponse = Field(..., description="Survey schema")


class EmailRecipient(BaseModel):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

отнаследуйся от huntflow_api_client.models.common.EmailRecipient

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему-то в доке displayName, а тут алиаса в name не вижу

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно, сделал!

None,
description="Survey questionary",
)
survey_answer_of_type_a: Optional[ApplicantLogSurveyAnswerTypeA] = Field(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему нет в доке у нас этого поля?
https://api.huntflow.ru/v2/docs#get-/accounts/-account_id-/applicants/-applicant_id-/logs

Image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в ответе от ручки, которую ты оставила в коммменте

)
external: List[ApplicantResume] = Field(..., description="Applicant's resume")
social: List[ApplicantSocial] = Field(..., description="List of applicant's social accounts")
reindex_job_id: str
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в доке нет такого поля

Image и кажется мы и не должны это отдавать, это техническая инфа, котрую клиенту не надо знать?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вообще если через АПИ, то отдает
Видимо в доке нет потому что reindex_job_id не имеет description
но раз в доке нет, то наверно и клиенте не надо

Image

"verification_date": "2020-01-01T00:00:00+03:00",
},
],
"reindex_job_id": "12345",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я все еще думаю что тут этому не место

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

убрал

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants