Add colocated media paths handling#381
Open
Spr-Aachen wants to merge 2 commits into
Open
Conversation
…e file paths properly
Modify lib/config.ts to automatically fill media.input from the corresponding content.path --------- Co-authored-by: Foxie <118339251+Foxie-404@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
This is how my config looks like
The media files in my project stored in the same folder as the markdown content, which is a common pattern in Astro.
However, when I write
cover: "./cover.jpg"in frontmatter (relative to the markdown file), theView on GitHublink in the editor incorrectly points toxxx/blob/main/cover.jpginstead ofxxx/blob/main/src/content/posts/guide/cover.jpg.Solution
Add
mediaInputprop toFileTeaserandImageTeasercomponents to handle relative media paths properly.Comparing to the previous PR, this solution comes with minus changes to the code files.
I understand the documentation recommends to use a central folder, but many users prefer colocated media and it has been proved to work with Decap CMS. So I still hope this could be supported.