Skip to content

fix: fall back illegal A5 auto-sync pairs to barrier #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HecreReed wants to merge 2 commits into from
Closed

fix: fall back illegal A5 auto-sync pairs to barrier #482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47c51e8
fix: fall back illegal a5 auto sync pairs to barrier
HecreReed Apr 14, 2026
7b45c74
chore: drop basic case updates from a5 sync fix
HecreReed Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions lib/PTO/Transforms/InsertSync/SyncCodegen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,26 @@ static pto::EventAttr getEventAttr(Builder &builder, int id) {
auto odsEventVal = static_cast<pto::EVENT>(id);
return pto::EventAttr::get(builder.getContext(), odsEventVal);
}

static bool isA5LowLevelSyncPipeLegal(PipelineType pipe) {
switch (pipe) {
case PipelineType::PIPE_S:
case PipelineType::PIPE_V:
case PipelineType::PIPE_MTE2:
case PipelineType::PIPE_MTE3:
return true;
default:
return false;
}
}

static bool shouldUseA5BarrierFallback(func::FuncOp func,
const SyncOperation *sync) {
if (!isTargetArchA5(func.getOperation()))
return false;
return !isA5LowLevelSyncPipeLegal(sync->GetActualSrcPipe()) ||
!isA5LowLevelSyncPipeLegal(sync->GetActualDstPipe());
}

static bool IsSameSyncSignature(const SyncOperation *existing,
const SyncOperation *candidate) {
Expand Down Expand Up @@ -335,6 +355,17 @@ void SyncCodegen::CreateSetWaitOpForSingleBuffer(IRRewriter &rewriter,
Operation *op,
SyncOperation *sync,
bool beforeInsert) {
if (shouldUseA5BarrierFallback(func_, sync)) {
auto pipeAllAttr = getPipeAttr(rewriter, PipelineType::PIPE_ALL);
if (beforeInsert || op->hasTrait<OpTrait::IsTerminator>()) {
rewriter.setInsertionPoint(op);
} else {
rewriter.setInsertionPointAfter(op);
}
rewriter.create<pto::BarrierOp>(op->getLoc(), pipeAllAttr);
return;
}

// [Fix] Terminator 强制前置插入
if (beforeInsert || op->hasTrait<OpTrait::IsTerminator>()) {
rewriter.setInsertionPoint(op);
Expand All @@ -357,6 +388,17 @@ void SyncCodegen::CreateSetWaitOpForMultiBuffer(IRRewriter &rewriter,
Operation *op,
SyncOperation *sync,
bool beforeInsert) {
if (shouldUseA5BarrierFallback(func_, sync)) {
auto pipeAllAttr = getPipeAttr(rewriter, PipelineType::PIPE_ALL);
if (beforeInsert || op->hasTrait<OpTrait::IsTerminator>()) {
rewriter.setInsertionPoint(op);
} else {
rewriter.setInsertionPointAfter(op);
}
rewriter.create<pto::BarrierOp>(op->getLoc(), pipeAllAttr);
return;
}
Comment on lines +391 to +400
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fallback barrier creation in CreateSetWaitOpForMultiBuffer also lacks deduplication logic. While the insertion point logic cannot be easily moved to the top due to the GetBufferSelected call later in the function, the barrier creation itself should still check for existing identical barriers to avoid redundancy.


// 注意：GetBufferSelected 可能需要在插入 Set/Wait 之前调用，以确保 SSA 顺序
// 但这里只是获取 Value，不影响 InsertionPoint 的设定
Value bufferSelected = GetBufferSelected(rewriter, op, sync);
Expand Down
Loading