docs: fix GitHub workspace path and pybind guidance#553
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project name casing from 'pto-as' to 'PTOAS' throughout the README and pins the pybind11 dependency to version 2.12.0 to ensure compatibility with LLVM/MLIR Python bindings. It also adds a troubleshooting note for specific compilation errors. Feedback suggests refining the version incompatibility note to specify that issues begin with pybind11 version 2.13.0 rather than 3.x to provide more accurate guidance for users.
| > 说明：当前 LLVM/MLIR Python 绑定与 `pybind11` 3.x 不兼容。 | ||
| > 如果编译 LLVM 时遇到 `def_property family does not currently support keep_alive` 等报错， | ||
| > 请先执行上面的降级命令。 |
There was a problem hiding this comment.
The note mentions incompatibility with pybind11 3.x, but the specific error def_property family does not currently support keep_alive actually started appearing with pybind11 2.13.0. Since pybind11 3.x is not yet a released version and the breakage begins at 2.13.0, it would be more accurate to reference version 2.13.0 or later to avoid confusion for users who might have 2.13.x installed.
| > 说明：当前 LLVM/MLIR Python 绑定与 `pybind11` 3.x 不兼容。 | |
| > 如果编译 LLVM 时遇到 `def_property family does not currently support keep_alive` 等报错， | |
| > 请先执行上面的降级命令。 | |
| > 说明：当前 LLVM/MLIR Python 绑定与 `pybind11` 2.13.0 及以上版本不兼容。 | |
| > 如果编译 LLVM 时遇到 `def_property family does not currently support keep_alive` 等报错， | |
| > 请先执行上面的降级命令。 |
Codex Review该评论由 review 机器人自动更新。
Summary未检查到 PR #553 存在问题 FindingsNo issues found. |
A3 板测完成（有跳过）
|
A5 板测成功
|
3 participants
Summary
Testing