Docs: add runtime logic, orchestration guides, and roadmap#151
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's documentation by providing comprehensive guides for various runtime orchestration mechanisms. It clarifies the architecture, data structures, and operational flows for different graph building strategies, enabling developers to better understand and implement custom orchestration logic. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces extensive documentation for the runtime and orchestration logic. The new guides for host_build_graph, aicpu_build_graph, and tensormap_and_ringbuffer are well-written, providing clear explanations of their architecture, data flows, and key components. This will be very helpful for developers working with these runtimes. I have one minor suggestion to improve clarity in one of the documents.
d9f0662 to
275a494
Compare
ChaoWao
left a comment
There was a problem hiding this comment.
Missing aicpu_build_graph INCORE_ORCHESTRATION_GUIDE.
|
Added missing aicpu_build_graph INCORE_ORCHESTRATION_GUIDE.md in src/runtime/aicpu_build_graph/docs/. Please re-review. (commit e15940e) |
…rite in English Address PR #151 review comment: the INCORE_ORCHESTRATION_GUIDE.md for aicpu_build_graph was placed under src/runtime/ instead of examples/ (inconsistent with host_build_graph and tensormap_and_ringbuffer guides). Move to examples/aicpu_build_graph/docs/ and rewrite as a practical English-language guide documenting the AicpuBuildApi, function signature, argument layout, and graph-building workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thank you for the detailed status update, @ChaoWao! I appreciate you addressing all the review comments, including the suggestion regarding "tensor argument order" in the The pull request looks good to merge. Great work on enhancing the documentation! |
ChaoWao
left a comment
There was a problem hiding this comment.
You shall rebase origin/main and try update the doc according to newest code status.
…rite in English Address PR #151 review comment: the INCORE_ORCHESTRATION_GUIDE.md for aicpu_build_graph was placed under src/runtime/ instead of examples/ (inconsistent with host_build_graph and tensormap_and_ringbuffer guides). Move to examples/aicpu_build_graph/docs/ and rewrite as a practical English-language guide documenting the AicpuBuildApi, function signature, argument layout, and graph-building workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
753dde0 to
4de4bdf
Compare
…rite in English Address PR #151 review comment: the INCORE_ORCHESTRATION_GUIDE.md for aicpu_build_graph was placed under src/runtime/ instead of examples/ (inconsistent with host_build_graph and tensormap_and_ringbuffer guides). Move to examples/aicpu_build_graph/docs/ and rewrite as a practical English-language guide documenting the AicpuBuildApi, function signature, argument layout, and graph-building workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c99c6a3 to
0717928
Compare
4fe67f5 to
0597757
Compare
Add comprehensive documentation for all three runtimes: - INCORE_ORCHESTRATION_GUIDE for each runtime (host_build_graph, aicpu_build_graph, tensormap_and_ringbuffer) - RUNTIME_LOGIC explaining execution flow and component interactions - ROADMAP for tensormap_and_ringbuffer advanced scheduling features All documentation placed in src/a2a3/runtime/ to align with PR #182's architecture-specific directory layout.
0597757 to
dc52c56
Compare
…-sys#151) Add comprehensive documentation for all three runtimes: - INCORE_ORCHESTRATION_GUIDE for each runtime (host_build_graph, aicpu_build_graph, tensormap_and_ringbuffer) - RUNTIME_LOGIC explaining execution flow and component interactions - ROADMAP for tensormap_and_ringbuffer advanced scheduling features All documentation placed in src/a2a3/runtime/ to align with PR hw-native-sys#182's architecture-specific directory layout.
Summary
Add comprehensive documentation for all three runtimes:
All documentation placed in
src/a2a3/runtime/to align with PR #182's architecture-specific directory layout.Testing