Add: batch_paged_attention device test for production-scale bfloat16#154
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive set of device tests for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a comprehensive device test for batched paged attention, including a Python golden model, C++ kernels for a custom accelerator, and orchestration logic. The implementation is well-structured and handles many important details for a production-scale test, such as using bfloat16, supporting variable sequence lengths, and implementing a chunked batching strategy. My review focuses on improving code clarity, maintainability, and robustness. I've suggested using static_cast for safer type conversions in C++, declaring a key configuration parameter as constexpr, and handling potential division-by-zero in the Python golden model to make it more robust.
Port batch_paged_attention from examples to device tests with: - bfloat16 data type (replacing float16 from example) - Production tile sizes (128x128/64x128) with runtime dispatch - Production scale: batch=64, head_dim=128, context_len=8193 - Variable sequence length test case (CaseVarSeq) - Tighter tolerance (RTOL/ATOL=1e-3 vs 1e-2 in example) - Chunked batch orchestration with IN_CORE_BATCH=16
8fd8610 to
22f76d9
Compare
…w-native-sys#154) Port batch_paged_attention from examples to device tests with: - bfloat16 data type (replacing float16 from example) - Production tile sizes (128x128/64x128) with runtime dispatch - Production scale: batch=64, head_dim=128, context_len=8193 - Variable sequence length test case (CaseVarSeq) - Tighter tolerance (RTOL/ATOL=1e-3 vs 1e-2 in example) - Chunked batch orchestration with IN_CORE_BATCH=16
Summary
batch_paged_attentionfrom examples to device testsTesting