Support: simplify benchmark workflow and fix case filtering#576
Open
zhusy54 wants to merge 1 commit intohw-native-sys:mainfrom
Open
Support: simplify benchmark workflow and fix case filtering#576zhusy54 wants to merge 1 commit intohw-native-sys:mainfrom
zhusy54 wants to merge 1 commit intohw-native-sys:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the benchmark documentation by removing the PTO-ISA pinning step and re-numbering the instructions. It also updates tools/benchmark_rounds.sh to include a --manual include flag when a case name is specified. A review comment identifies that this flag is unsupported by run_example.py, which could cause errors for legacy examples, and suggests applying it conditionally only when a test file is present.
- Restructure benchmark_rounds.sh to prefer test_*.py over run_example.py - Fix: only pass --manual include to test_*.py; run_example.py does not support this flag and would crash when case_name is specified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--manual includewhen--caseis specified inbenchmark_rounds.shto ensure only the targeted case runs (without it, auto-discovery may include unintended examples)Testing
benchmark_rounds.sh --caseruns only the specified example