Docs: update MULTI_RING.md and RUNTIME_LOGIC.md for PR #622 refactor#625
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the scope management system within the PTO2 runtime, replacing dynamic task tracking with a range-based approach using task IDs per ring. It unifies task and heap allocation into a single PTO2TaskAllocator and updates the shared memory layout and documentation accordingly. Additionally, branch prediction hints were added to hot paths. Feedback suggests that the removal of a prefetch in pto2_prefetch_payload might negatively impact performance for tasks with a high number of inline fanins.
746ef71 to
ad22605
Compare
refactor Align documentation with the PTO2SharedMemoryRingHeader consolidation: - RingHeader now carries per-ring data pointers and accessors - SharedMemoryHandle reduced to lifecycle-only role - RingSchedState uses ring pointer instead of cached members - Remove stale heap_tail_gen / dep_list_pool references - Update SM layout, size formula, and watermark pseudocode
ad22605 to
cd0d863
Compare
jvjhfhg
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align documentation with the PTO2SharedMemoryRingHeader consolidation:
- RingHeader now carries per-ring data pointers and accessors
- SharedMemoryHandle reduced to lifecycle-only role
- RingSchedState uses ring pointer instead of cached members
- Remove stale heap_tail_gen / dep_list_pool references
- Update SM layout, size formula, and watermark pseudocode