Skip to content

Docs: update MULTI_RING.md and RUNTIME_LOGIC.md for PR #622 refactor#625

Merged
jvjhfhg merged 1 commit into
hw-native-sys:mainfrom
poursoul:remove-scope-tasks
Apr 22, 2026
Merged

Docs: update MULTI_RING.md and RUNTIME_LOGIC.md for PR #622 refactor#625
jvjhfhg merged 1 commit into
hw-native-sys:mainfrom
poursoul:remove-scope-tasks

Conversation

@poursoul
Copy link
Copy Markdown
Collaborator

@poursoul poursoul commented Apr 21, 2026

Align documentation with the PTO2SharedMemoryRingHeader consolidation:
- RingHeader now carries per-ring data pointers and accessors
- SharedMemoryHandle reduced to lifecycle-only role
- RingSchedState uses ring pointer instead of cached members
- Remove stale heap_tail_gen / dep_list_pool references
- Update SM layout, size formula, and watermark pseudocode

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the scope management system within the PTO2 runtime, replacing dynamic task tracking with a range-based approach using task IDs per ring. It unifies task and heap allocation into a single PTO2TaskAllocator and updates the shared memory layout and documentation accordingly. Additionally, branch prediction hints were added to hot paths. Feedback suggests that the removal of a prefetch in pto2_prefetch_payload might negatively impact performance for tasks with a high number of inline fanins.

@poursoul poursoul force-pushed the remove-scope-tasks branch from 746ef71 to ad22605 Compare April 21, 2026 11:58
@poursoul poursoul changed the title Refactor: replace scope task buffer with per-ring task_id ranges [WIP] Refactor: replace scope task buffer with per-ring task_id ranges Apr 21, 2026
 refactor

Align documentation with the PTO2SharedMemoryRingHeader consolidation:
- RingHeader now carries per-ring data pointers and accessors
- SharedMemoryHandle reduced to lifecycle-only role
- RingSchedState uses ring pointer instead of cached members
- Remove stale heap_tail_gen / dep_list_pool references
- Update SM layout, size formula, and watermark pseudocode
@poursoul poursoul force-pushed the remove-scope-tasks branch from ad22605 to cd0d863 Compare April 22, 2026 01:55
@poursoul poursoul changed the title [WIP] Refactor: replace scope task buffer with per-ring task_id ranges Docs: update MULTI_RING.md and RUNTIME_LOGIC.md for PR #622 refactor Apr 22, 2026
@jvjhfhg jvjhfhg merged commit 0e79be9 into hw-native-sys:main Apr 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants