Repository navigation
fix(notify): keep --auto silent on stdout so Codex Stop hooks parse - #30
Merged
Merged
Conversation
Codex reads a Stop hook's stdout as JSON. `hwip notify --auto` printed "Push sent: <id>" after a successful push, so every Codex turn ended with "hook returned invalid stop hook JSON output". `--auto` is the hook mode, so it now prints nothing on success; `--json` still prints.
|
🎉 This PR is included in version 0.1.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
Codex는 Stop 훅 stdout을 JSON으로 읽는다.
hwip notify --auto가 push 성공 뒤Push sent: <id>를 찍어 Codex 턴마다hook returned invalid stop hook JSON output이 떴다(codex-cli 0.166.0 실측).변경
--auto(훅 모드)는 성공 시 stdout에 아무것도 안 쓴다.--json은 그대로 출력.cli-run.test.ts에 두 케이스 추가. 수정 전 코드에서 첫 케이스가 실패하는 것 확인.검증
npx tsc --noEmit통과npx vitest run: 5613 통과, 8 실패 —src/http-proxy.test.ts8건이며origin/main(3c3389b)에서도 같은 8건이 실패한다(이 변경과 무관, 로컬 환경 문제로 추정·미조사).배포 후 기존 설치는
npm i -g @hwip/cli만으로 고쳐진다(훅 명령은 그대로).🤖 Generated with Claude Code