Repository navigation
feat(blocked-prompt): read Claude questions and plan approval - #33
Merged
Merged
Conversation
AskUserQuestion (single, multi-select with Submit, review of several answers) and ExitPlanMode now parse into the same permission-shaped prompt the approval dialogs use, so existing apps render them unchanged. Rows that need typed text are not offered and a dialog being typed into is not read. Plan and review dialogs lack the footer the blocked rule keys on, so add a rule for them (bundle 2026.11.01.2, mirrored in hwip).
tak-bro
force-pushed
the
feat/claude-dialog-cards
branch
from
November 1, 2026 02:01
9db4cbf to
5e14f96
Compare
tak-bro
marked this pull request as ready for review
November 1, 2026 02:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Claude Code's AskUserQuestion (single question, multi-select with Submit, review of several answers) and ExitPlanMode (plan approval) are now read from the pane and sealed like the Bash/Edit/Create approvals, so the phone shows a card with options it can answer.
src/blocked-prompt-claude-dialogs.ts(parseClaudeQuestion,parseClaudePlan), wired intoREADERS.claudeafterparseClaudeDialog.kind: "permission"shape: the deployed iOS/Android apps render it unchanged (a newkindwould be dropped by every installed app). Onlytitletells the screens apart.Type something,Chat about this,Tell Claude what to change) are not options; a dialog whose highlight is on such a row, or that is being typed into, is not read at all.Submitoption (itsnis not a screen number).detailTruncated), plan file path asnote,Yes, and use auto modeispersistent(PERSISTENTgainedauto mode).esc/enter to selectfooter, so the existing blocked rule missed them (state read as idle and no prompt was ever sealed). New ruleclaude-blocked-plan-or-review; bundle andPUBLISHED_FLOOR→2026.11.01.2.src/fixtures/panes/; README paragraph updated.Merge order (stacked)
hwip#663 → hwip#664 → server deploy → cli#32 → cli#33. This PR is stacked on cli#32 (
feat/codex-approval; base is that branch) and needs the hwip mirror (#664) merged and deployed first (PUBLISHED_FLOOR). Bundle and floor carry both the Codex and Claude rules at2026.11.01.2. After cli#32 merges, retarget the base tomain.PERSISTENTonly gained an alternative; a test pins that the Codexdon't ask againchoices (exec, wrapped exec, edit fixtures) and the Claude Bash ones are still marked, and plain ones are not.Not in this PR
ifPromptis the hash of the screen, so typing changes it and the follow-up key is refused (prompt_changed). Needs a new wire shape and app UX.~/.claude/plans/*.md).Verification
npx vitest run --exclude src/http-proxy.test.ts: 5603 passed, 1 skipped (http-proxy.test.tshas 8 failures on main already).npx tsc --noEmit: clean./review --full: no Critical/Important; 3 Nice-to-have (two fixed in 9db4cbf).