Skip to content

feat(install): link the phone app on the last screen - #39

Merged
tak-bro merged 1 commit into
mainfrom
feat/install-campaign-link
Nov 4, 2026
Merged

tak-bro merged 1 commit into
mainfrom
feat/install-campaign-link

Conversation

@tak-bro

@tak-bro tak-bro commented Nov 4, 2026

Copy link
Copy Markdown
Member

무엇

hwip install 끝 화면(closingLine 뒤, 알림 안내 앞)에 앱 받기 안내 두 줄 추가. 사용자 승인(팀장 전달).

  Get the app: https://apps.apple.com/app/id6818053606?ct=cli-install
  Android:     https://play.google.com/store/apps/details?id=app.hwip&referrer=utm_source%3Dcli-install

형식은 hwip main apps/landing/src/store-urls.js 의 appStoreCampaignUrl / playStoreCampaignUrl 과 같다(pt 는 아직 없음). 다른 출력 줄 불변.

검증

  • npm run build 통과
  • npm test: 5669 pass / 8 fail — 실패는 전부 src/http-proxy.test.ts(이 PR 이 안 건드림). 변경 없는 cli main 체크아웃에서도 같은 8개 실패(이 머신 환경)
  • 새 테스트 install-flow.test.ts: 두 URL 을 리터럴로 고정하고 closing line → 앱 링크 → 알림 안내 순서를 확인
  • /review: Approve (Critical·Important 0). nit: 설치 단계 실패 시에도 링크가 나온다(의도대로 둠)

배포: 없음 (npm 릴리스는 semantic-release, 머지 뒤 자동)

🤖 Generated with Claude Code

Print the App Store and Google Play links with ct/utm_source=cli-install after the closing line, in the same shape as the landing's campaign URLs.
@tak-bro
tak-bro marked this pull request as ready for review November 4, 2026 10:45
@tak-bro
tak-bro merged commit 8dd6990 into main Nov 4, 2026
4 checks passed
@tak-bro
tak-bro deleted the feat/install-campaign-link branch November 4, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant