Repository navigation
feat(install): link the phone app on the last screen - #39
Merged
Merged
Conversation
Print the App Store and Google Play links with ct/utm_source=cli-install after the closing line, in the same shape as the landing's campaign URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇
hwip install끝 화면(closingLine 뒤, 알림 안내 앞)에 앱 받기 안내 두 줄 추가. 사용자 승인(팀장 전달).형식은 hwip main
apps/landing/src/store-urls.js의appStoreCampaignUrl/playStoreCampaignUrl과 같다(pt 는 아직 없음). 다른 출력 줄 불변.검증
npm run build통과npm test: 5669 pass / 8 fail — 실패는 전부src/http-proxy.test.ts(이 PR 이 안 건드림). 변경 없는 cli main 체크아웃에서도 같은 8개 실패(이 머신 환경)install-flow.test.ts: 두 URL 을 리터럴로 고정하고 closing line → 앱 링크 → 알림 안내 순서를 확인배포: 없음 (npm 릴리스는 semantic-release, 머지 뒤 자동)
🤖 Generated with Claude Code