Repository navigation
fix(herdr): report hwip cc to herdr again and survive its restarts - #1
Merged
Merged
Conversation
tmux 3.5a's `display-message -p` prints a unit separator as the literal `\037`, so the three herdr options arrived as one value, the socket read as empty, and the hook exited before every report: no `hwip cc` pane ever showed in herdr. Read the options one per line instead, and make the test's tmux stub escape control characters the way tmux does. herdr forgets every report when it restarts, and the hook skips a state equal to the last one it sent, so an idle agent stayed missing. herdr recreates its socket on start: keep the socket in the state file and resend when it is newer than the last report (a `test -nt`, no fork).
tak-bro
added a commit
that referenced
this pull request
Oct 19, 2026
Ship the herdr fix (#1) to existing installs; Claude Code only refreshes a plugin when its version changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇이 문제였나
hwip ccpane 이 herdr 사이드바에 한 번도 뜨지 않았다. tmux 3.5adisplay-message -p가\x1f를 리터럴\037로 출력해 세 옵션이 한 값으로 들어오고, socket 이 비어 hook 이 매번 보고 전에exit 0.변경
hooks/hwip-herdr.sh: 옵션을 한 줄에 하나씩 읽음(빈 필드 보존). state 파일에 socket 경로를 기록하고 socket 이 마지막 보고보다 새로우면(herdr 는 시작 시 socket 재생성) 같은 state 도 재보고 — builtintest -nt, fork 없음.tests/test-hwip-herdr.sh: tmux stub 이 실 tmux 처럼 제어문자를 이스케이프(기존 stub 은 raw 로 넘겨 결함을 가렸다 — 픽스 전 12건 red) + herdr 재시작 3행(픽스 전 red).docs/HOOKS-EXPLAINED.md갱신.검증
tests/run-all.sh16/16 suites.hwip ccpane 에서 실행 →herdr agent list에hwip cc working.짝 PR: hwipit/cli (herdr 네이티브 통합의 죽은 pane env).
🤖 Generated with Claude Code