Skip to content

[node-maintenance-repair/7] Validate the sealed candidate on a separate runner - #50

Open
omry wants to merge 1 commit into
pr49from
pr50
Open

omry wants to merge 1 commit into
pr49from
pr50

Conversation

@omry

@omry omry commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Validate the sealed preparation candidate on a separate read-only runner. Reuse native Git patch/index checks, the strict request and audit envelope, frozen installation and the configured project checks. Reject dependency/configuration drift, remaining selected advisories and new findings.

Keep validation logs and results separate from the immutable preparation artifact. The five workflow inputs stay unchanged; publication and normal-audit retention remain later slices.

Validation: 1,455 Python tests, Ruff lint/format, Pyrefly, and real Node 24.22.1 with pnpm 11.20.0/11.21.0 success, failure, drift and artifact-tamper cases. Current-agent and fresh independent reviews are clean. Hosted validation remains pending regular PR approval.


…te runner

Validate the sealed preparation candidate on a separate read-only runner. Reuse native Git patch/index checks, the strict request and audit envelope, frozen installation and the configured project checks. Reject dependency/configuration drift, remaining selected advisories and new findings.

Keep validation logs and results separate from the immutable preparation artifact. The five workflow inputs stay unchanged; publication and normal-audit retention remain later slices.

Validation: 1,455 Python tests, Ruff lint/format, Pyrefly, and real Node 24.22.1 with pnpm 11.20.0/11.21.0 success, failure, drift and artifact-tamper cases. Current-agent and fresh independent reviews are clean. Hosted validation remains pending regular PR approval.
@omry
omry changed the base branch from main to pr49 October 25, 2026 15:35
@omry
omry added this pull request to stack #44 October 25, 2026 15:35
@omry

omry commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:7406792d784c89259e37b60201c1b09a0edb3cbf97bbfc70f2e4a8707736b9d2",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:7406792d784c89259e37b60201c1b09a0edb3cbf97bbfc70f2e4a8707736b9d2",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 121211917963
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 121211918181
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 121211918151
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 121211918246
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 121211918158
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 121211918265
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 121211918183
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 121211918147
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:8037efd0b645692a19a6ab9f9d9d37a335d007b9f3ce9650c15c2073cb2abe6b",
      "review_request": {
        "body_digest": "sha256:61c229078846abe469e842cf4082919180d288f86e12844b7270f9b746055829",
        "id": 6399725452
      },
      "review_result": {
        "body_digest": "sha256:a0903f3e18e75add0c023d2aa0a4781e3d5411c4ab2fb7cb351b2dcc984e1eab",
        "id": 6399740793
      }
    },
    "evidence_fingerprint": "sha256:b5ce2380503b184761ae50c41a609b63b6c1016314c3c3b7c4255d42972fc44c",
    "head_sha": "0ef9690822c45923eede8a0ef769405b7492f4e9",
    "operation_identity": "sha256:8037efd0b645692a19a6ab9f9d9d37a335d007b9f3ce9650c15c2073cb2abe6b",
    "review_request_id": 6399725452,
    "review_result_id": 6399740793,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:7406792d784c89259e37b60201c1b09a0edb3cbf97bbfc70f2e4a8707736b9d2",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "repair-app",
      "run_id": 121211917963
    },
    {
      "conclusion": "SUCCESS",
      "name": "test",
      "run_id": 121211918181
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, npm, 11.9.0)",
      "run_id": 121211918151
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.20.0)",
      "run_id": 121211918246
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.21.0)",
      "run_id": 121211918158
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, npm, 11.9.0)",
      "run_id": 121211918265
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.20.0)",
      "run_id": 121211918183
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.21.0)",
      "run_id": 121211918147
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 121211917963,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211917963"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 121211918181,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211918181"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 121211918151,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211918151"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 121211918246,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211918246"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 121211918158,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211918158"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 121211918265,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211918265"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 121211918183,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211918183"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 121211918147,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40207644688/job/121211918147"
        }
      ],
      "head_sha": "0ef9690822c45923eede8a0ef769405b7492f4e9",
      "id": "sha256:e184f9f92a7b34bc022d92d1f88c32ebb03f9b0bb9e5fa074992621348740ee8",
      "required_checks": [
        "repair-app",
        "test",
        "toolchain (22, npm, 11.9.0)",
        "toolchain (22, pnpm, 11.20.0)",
        "toolchain (22, pnpm, 11.21.0)",
        "toolchain (24, npm, 11.9.0)",
        "toolchain (24, pnpm, 11.20.0)",
        "toolchain (24, pnpm, 11.21.0)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr49",
    "base_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
    "body_digest": "sha256:30d530e9a09a9ede3b7df4cb9af560cb75f12e9ca5c29475274314a574c69bef",
    "body_identity_version": 2,
    "diff_digest": "sha256:ba93a3b5128334814c4f007eae79a1fccb8a4874eecc73213322c1382fc1ee90",
    "head_ref": "pr50",
    "head_sha": "0ef9690822c45923eede8a0ef769405b7492f4e9",
    "pr": 50,
    "repository": "hydra-ecosystem/github-actions",
    "scope_authority": [
      {
        "digest": "sha256:e8a1d042e9162180df2fb9f0643a81a04b06327116c444b942c3b2a9f7f45cdf",
        "path": ".github/workflows/validate.yml"
      },
      {
        "digest": "sha256:4e1af4fc1733aab85da509e5e3142829be05695ad41873adef8d2fe5930292c0",
        "path": "README.md"
      },
      {
        "digest": "sha256:b60d30b53b42d9c2c18eae03e05af25cb4e91e737de079477d58e2ed93576ddb",
        "path": "node/contract.json"
      }
    ],
    "title_digest": "sha256:d03acc2679b2525e3068caf0b04e3b0252980704b97c1906d6d1153c8342e517"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-10-25T15:35:12Z",
      "base_ref": "pr49",
      "base_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "body_digest": "sha256:61c229078846abe469e842cf4082919180d288f86e12844b7270f9b746055829",
      "created_at": "2026-10-25T15:47:21Z",
      "head_sha": "0ef9690822c45923eede8a0ef769405b7492f4e9",
      "id": 6399725452,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr49",
      "base_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "body_digest": "sha256:a0903f3e18e75add0c023d2aa0a4781e3d5411c4ab2fb7cb351b2dcc984e1eab",
      "commit_id": "0ef9690822c45923eede8a0ef769405b7492f4e9",
      "id": 6399740793,
      "inline_message_ids": [],
      "request_comment_id": 6399725452,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-25T15:48:47Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:7406792d784c89259e37b60201c1b09a0edb3cbf97bbfc70f2e4a8707736b9d2",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:ba93a3b5128334814c4f007eae79a1fccb8a4874eecc73213322c1382fc1ee90",
      "finding_ids": [],
      "invariants": [],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "0ef9690822c45923eede8a0ef769405b7492f4e9",
      "review_observation_id": null,
      "review_request_id": 6399725452,
      "review_result_id": 6399740793,
      "reviewed_head": "0ef9690822c45923eede8a0ef769405b7492f4e9",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 25, 2026 15:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T15:48:48.479047Z 0ef9690 Manual request
🔒 Security Review ✅ Completed 2026-10-25T15:48:05.629559Z 0ef9690 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Exact head: 0ef9690

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 0ef9690822

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant