-
Notifications
You must be signed in to change notification settings - Fork 438
feat(dashboards): per-column color on table tiles #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b74e0df
feat(dashboards): per-column color on table tiles
alex-fedotyev d13319f
fix(dashboards): close the color drawer only after a valid submit
alex-fedotyev a51df75
fix(dashboards): coerce numeric-string cells before conditional color
alex-fedotyev 6092425
Merge branch 'main' into alex/table-cell-color
jordan-simonovski 1678fc4
Merge branch 'main' into alex/table-cell-color
alex-fedotyev 24f8138
Merge branch 'main' into alex/table-cell-color
alex-fedotyev 4c1ecd3
test(dashboards): clear net-new eslint warnings in table color tests
alex-fedotyev 9727fa1
Merge branch 'main' into alex/table-cell-color
alex-fedotyev f2a7709
Merge branch 'main' into alex/table-cell-color
karl-power bb0cafe
Merge branch 'main' into alex/table-cell-color
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| "@hyperdx/common-utils": minor | ||
| "@hyperdx/app": minor | ||
| --- | ||
|
|
||
| Add per-column color to dashboard table tiles. On builder table tiles you can | ||
| now set a static color on a column and layer ordered conditional rules (for | ||
| example `> 500` turns the cell red), the table-cell counterpart of the | ||
| number-tile color. Rules are authored from the column editor and applied per | ||
| cell at render, reusing the existing palette tokens so colors reflow across | ||
| light and dark themes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.