Skip to content

fix(app): clear VirtualMultiSelect search input on select/add#2676

Merged
kodiakhq[bot] merged 3 commits into
mainfrom
cursor/clear-virtualmultiselect-input-af97
Jul 22, 2026
Merged

fix(app): clear VirtualMultiSelect search input on select/add#2676
kodiakhq[bot] merged 3 commits into
mainfrom
cursor/clear-virtualmultiselect-input-af97

Conversation

@pulpdrew

@pulpdrew pulpdrew commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Why

Previously, when a user typed a search value into the VirtualMultiSelect and then added it as a value, the typed text was left behind in the input. This diverges from the behavior of a non-virtualized Mantine MultiSelect with search, which clears the input after a value is selected.

This has been requested by at least 3 independent users.

Before

Screen.Recording.2026-07-22.at.12.43.26.PM.mov

After

Screen.Recording.2026-07-22.at.12.43.01.PM.mov

Testing

This can be tested in the preview environment by creating a dashboard filter and searching for + selecting a value.

Closes HDX-4816

@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8475f88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Jul 22, 2026 5:23pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hyperdx-storybook Ignored Ignored Preview Jul 22, 2026 5:23pm

Request Review

@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR clears the virtual multi-select search box after a value is chosen. The main changes are:

  • Added a patch changeset for @hyperdx/app.
  • Updated VirtualMultiSelect to reset search after selecting or toggling a value.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
packages/app/src/components/VirtualMultiSelect/VirtualMultiSelect.tsx Clears the local search state after a value is selected or toggled.
.changeset/clear-virtualmultiselect-input.md Adds a patch changeset for the app package.

Reviews (4): Last reviewed commit: "Merge branch 'main' into cursor/clear-vi..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 238 passed • 1 skipped • 1067s

Status Count
✅ Passed 238
❌ Failed 0
⚠️ Flaky 5
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew
pulpdrew force-pushed the cursor/clear-virtualmultiselect-input-af97 branch from 3563ebf to 88af915 Compare July 22, 2026 16:39
@pulpdrew pulpdrew added automerge ai-generated AI-generated content; review carefully before merging. labels Jul 22, 2026
@pulpdrew
pulpdrew marked this pull request as ready for review July 22, 2026 16:45
@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 4
  • Branch: cursor/clear-virtualmultiselect-input-af97
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a one-line change: handleSelectValue now calls setSearch('') after toggling a value (packages/app/src/components/VirtualMultiSelect/VirtualMultiSelect.tsx:73), making the option-submit path symmetric with the existing Enter-to-add path at line 103. The logic is correct, introduces no new failure mode on the happy path, and matches the stated goal of aligning with Mantine MultiSelect behavior.

🟡 P2 — recommended

  • packages/app/src/components/VirtualMultiSelect/VirtualMultiSelect.tsx:73 — The new clear-on-select behavior has no test coverage, and the component has no test file at all, so the fix and its symmetry with the Enter path are unverified against regression.
    • Fix: Add a colocated test that types a search term, submits an option via onOptionSubmit, and asserts the input value resets to empty.
    • testing, correctness
🔵 P3 nitpicks (1)
  • packages/app/src/components/VirtualMultiSelect/VirtualMultiSelect.tsx:73 — Because handleSelectValue toggles, submitting an already-selected option to deselect it now also clears the search term, resetting the filtered list mid-interaction; confirm this side effect on the deselect path is intended.
    • Fix: If deselect should preserve the active filter, guard the setSearch('') call to run only when a value is added.

Reviewers (7): correctness, testing, maintainability, project-standards, kieran-typescript, julik-frontend-races, agent-native.

Testing gaps:

  • No test file exists for VirtualMultiSelect; neither the new clear-on-select behavior nor the existing Enter-to-add clearing is covered.

@pulpdrew
pulpdrew requested review from a team, fleon and teeohhem and removed request for a team and fleon July 22, 2026 17:02
@kodiakhq
kodiakhq Bot merged commit dbe1496 into main Jul 22, 2026
27 checks passed
@kodiakhq
kodiakhq Bot deleted the cursor/clear-virtualmultiselect-input-af97 branch July 22, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated AI-generated content; review carefully before merging. automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants