chore: migrate to hyperledger-firefly org, firefly deps, Go 1.26.4#198
Open
dan-r wants to merge 2 commits into
Open
chore: migrate to hyperledger-firefly org, firefly deps, Go 1.26.4#198dan-r wants to merge 2 commits into
dan-r wants to merge 2 commits into
Conversation
…cies Signed-off-by: Daniel Raper <daniel.raper@kaleido.io>
Signed-off-by: Daniel Raper <daniel.raper@kaleido.io>
dan-r
force-pushed
the
chore/update-module-path
branch
from
495e1ca to
11eae17
Compare
onelapahead
reviewed
Jun 28, 2026
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.23-alpine3.20 AS builder | |||
| FROM golang:1.26.4-alpine3.24 AS builder | |||
Contributor
There was a problem hiding this comment.
I don't recommend pinning the patch version for Go builds, it ensures we patch CVEs whenever we build
| module github.com/hyperledger-firefly/evmconnect | ||
|
|
||
| go 1.23.0 | ||
| go 1.26.4 |
Contributor
There was a problem hiding this comment.
I think its best to avoid pinning to specific patches go 1.26.0 is still compatible with newer Go 1.26 versions, but if a project importing this was on an older go 1.26 (for whatever reason) we force it to upgrade.
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: "1.23" | ||
| go-version: "1.26.4" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases needed for signer and transaction-manager. Currently just pointing @ main