fix: add set -o pipefail to fablo.sh to prevent silent pipeline failures#745
Open
Nikhil2510192 wants to merge 1 commit into
Open
fix: add set -o pipefail to fablo.sh to prevent silent pipeline failures#745Nikhil2510192 wants to merge 1 commit into
Nikhil2510192 wants to merge 1 commit into
Conversation
Signed-off-by: jiel <nikhilpagadala2006@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds set -o pipefail to the top-level fablo.sh entrypoint script so pipeline failures are not silently ignored when set -e is enabled, aligning behavior with the reported bug in #744.
Changes:
- Enable
pipefailinfablo.shso any failure within a pipeline causes the script to fail fast.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
fablo.shwas missingset -o pipefail, allowing pipeline errorsto be silently swallowed. With only
set -e, the exit code of apipeline is determined by the last command — if an earlier command
fails, the script continues executing without error.
Fix:
Added
set -o pipefailafterset -eon line 2 offablo.sh.Testing
npm run test:unit✅ (17/17 passing)Fixes #744