Ensure that logging context is passed through for webhook deliveries#1703
Merged
EnriqueL8 merged 1 commit intohyperledger:mainfrom Apr 14, 2026
Merged
Ensure that logging context is passed through for webhook deliveries#1703EnriqueL8 merged 1 commit intohyperledger:mainfrom
EnriqueL8 merged 1 commit intohyperledger:mainfrom
Conversation
EnriqueL8
reviewed
Oct 13, 2025
Contributor
EnriqueL8
left a comment
There was a problem hiding this comment.
looks good - a comment on verifying where this is called if it's added already
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 342 342
Lines 25022 25024 +2
=======================================
+ Hits 25008 25010 +2
Misses 10 10
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Dave Crighton <dave.crighton@kaleido.io> Made-with: Cursor
EnriqueL8
approved these changes
Apr 14, 2026
Contributor
EnriqueL8
left a comment
There was a problem hiding this comment.
Thanks @davecrighton - looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR ensures that the parent request log context is used when constructing the log context for webhook deliveries. This makes it easier to correlate the root cause of webhook delivery failures with the rest of the log stream for a particular event.
Fixes # n/a
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.