Skip to content

Ensure that logging context is passed through for webhook deliveries#1703

Merged
EnriqueL8 merged 1 commit intohyperledger:mainfrom
davecrighton:main
Apr 14, 2026
Merged

Ensure that logging context is passed through for webhook deliveries#1703
EnriqueL8 merged 1 commit intohyperledger:mainfrom
davecrighton:main

Conversation

@davecrighton
Copy link
Copy Markdown
Contributor

@davecrighton davecrighton commented Oct 8, 2025

Proposed changes

This PR ensures that the parent request log context is used when constructing the log context for webhook deliveries. This makes it easier to correlate the root cause of webhook delivery failures with the rest of the log stream for a particular event.

Fixes # n/a


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

Copy link
Copy Markdown
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - a comment on verifying where this is called if it's added already

Comment thread internal/events/webhooks/webhooks.go Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.94%. Comparing base (7e50b48) to head (1cb77c5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1703   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         342      342           
  Lines       25022    25024    +2     
=======================================
+ Hits        25008    25010    +2     
  Misses         10       10           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
Made-with: Cursor
Copy link
Copy Markdown
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davecrighton - looks good

@EnriqueL8 EnriqueL8 merged commit fc28031 into hyperledger:main Apr 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants