Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for unified accounts in the SendDialog component by integrating the useInfoUserAbstraction hook. It adjusts the account type logic, asset sending parameters, and UI visibility based on whether the user has a unified account. The review feedback suggests removing debug console.log statements and cleaning up an unused variable assignment in the asset transfer logic.
| console.log("[SendDialog] sending", { tokenId, destination, amount, isUnifiedAccount }); | ||
| if (isUnifiedAccount) { |
There was a problem hiding this comment.
Debug console.log statements should be removed before merging to production to keep the console clean and avoid leaking internal state.
if (isUnifiedAccount) {
| const result = await sendAsset({ | ||
| destination, | ||
| sourceDex: "spot", | ||
| destinationDex: selectedToken === DEFAULT_QUOTE_TOKEN ? "" : "spot", | ||
| token: tokenId, | ||
| amount, | ||
| }); | ||
| console.log("[SendDialog] sendAsset result", result); |
There was a problem hiding this comment.
Debug console.log statements should be removed. Additionally, the result of sendAsset is unused in this scope, so the assignment can be removed for cleaner code.
| const result = await sendAsset({ | |
| destination, | |
| sourceDex: "spot", | |
| destinationDex: selectedToken === DEFAULT_QUOTE_TOKEN ? "" : "spot", | |
| token: tokenId, | |
| amount, | |
| }); | |
| console.log("[SendDialog] sendAsset result", result); | |
| await sendAsset({ | |
| destination, | |
| sourceDex: "spot", | |
| destinationDex: selectedToken === DEFAULT_QUOTE_TOKEN ? "" : "spot", | |
| token: tokenId, | |
| amount, | |
| }); |
Deploying hyperterminal with
|
| Latest commit: |
53219cc
|
| Status: | ⚡️ Build in progress... |
1 participant
No description provided.